[18.0] [MIG] account_banking_mandate_sale_contact: Migration to 18.0 #1465
Conversation
|
hello @bizzappdev, do you have any plans to continue this work? If you have any problems, I am here to help you. |
@xaviedoanhduy Yes, we are planning to continue the work. The module is ready, but for some strange reason (it might be a dependent module from test-requirement.txt), it is causing the test cases to fail. We are investigating in depth. |
|
as you said, it happens in 2 modules I think when this PR #1467 is merged the CI will be green when you rebase with the original branch |
| _inherit = "sale.order" | ||
|
|
||
| @api.depends( | ||
| "partner_id", "partner_invoice_id", "partner_shipping_id", "payment_mode_id" |
There was a problem hiding this comment.
You don't need to copy all the dependent fields in this decorator, just add new fields that don't appear in the original function and the ORM will automatically join them
bizzappdev
force-pushed
the
18.0-mig-account_banking_mandate_sale_contact-BAD
branch
from
453d99e to
68fefb6
Compare
|
hello @bizzappdev, #1467 has been merged, is this PR ready? |
Currently translated at 100.0% (14 of 14 strings) Translation: bank-payment-17.0/bank-payment-17.0-account_banking_mandate_sale_contact Translate-URL: https://translation.odoo-community.org/projects/bank-payment-17-0/bank-payment-17-0-account_banking_mandate_sale_contact/it/
bizzappdev
force-pushed
the
18.0-mig-account_banking_mandate_sale_contact-BAD
branch
from
68fefb6 to
93b12ee
Compare
|
@xaviedoanhduy Yes, it is now ready for review, but the dependency Module migration PR is still there, which will restrict merging this PR. |
| help="The partner of the sales in which odoo will search for the mandate" | ||
| title="The contact of this company in which odoo will search for the mandate on sales. 
-Customer Mandate: Odoo will look the mandate in the sale partner, whether is an individual or the company. 
-Commercial Customer Mandate: Odoo will look the mandate in the sale partner company. 
-Invoice Address Mandate: Odoo will look the mandate in the sale invoice address. 
-Delivery Address Mandate: Odoo will look the mandate in the sale delivery address. 
-False: Odoo will use the first mandate he founds for the partner company. Odoo will also use this option if no default mandate is found in the partner of the above options" | ||
| > | ||
| <field name="sale_default_mandate_contact" /> |
There was a problem hiding this comment.
| <field name="sale_default_mandate_contact" /> | |
| <field name="sale_default_mandate_contact" class="oe_inline" /> |
before
after
| <field name="model">res.partner</field> | ||
| <field | ||
| name="inherit_id" | ||
| ref="account_payment_partner.view_partner_property_form" |
There was a problem hiding this comment.
| ref="account_payment_partner.view_partner_property_form" | |
| ref="account_banking_mandate_contact.view_partner_property_form" |
I think this will look clearer
There was a problem hiding this comment.
Both changes are applied.
bizzappdev
force-pushed
the
18.0-mig-account_banking_mandate_sale_contact-BAD
branch
from
93b12ee to
8fc7933
Compare
|
Hello @bizzappdev, Do you plan to continue this work? I see that the dependency module has already been merged. |
bizzappdev
force-pushed
the
18.0-mig-account_banking_mandate_sale_contact-BAD
branch
from
8fc7933 to
bede0e5
Compare
|
Yes sure. Also the test requirement file has been taken care of. |
Thanks for working on this! |
There was a problem hiding this comment.
Tested locally, it works as expected.
Thank you very much for your work, @bizzappdev
|
/ocabot migration account_banking_mandate_sale_contact |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at be28263. Thanks a lot for contributing to OCA. ❤️ |
7 participants
Dependency PR for module account_banking_mandate_sale #1456